Migrate CSS names: selected background colors. #8103
Merged
+15
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note: staging deployment ongoing |
Member
|
I dare not review colors, LGTM |
Contributor
|
IMO the sort-selection and completion highlight bright mode aliceblue color has too little contrast: Not sure I see the dark-mode color come through for search completion (looks similar to bright mode |
Collaborator
Author
|
Reverted the light-theme color change for now, as I couldn't find a named color close to the original one that has more contrast (still kept the rename). Oh, the search completion is outside of |
sigurdm
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial reimplementation of #8064, only doing the selected background color in this PR.
light theme changes:
#e7f8ff#cccccc->#e7f8ffdark theme changes:
#206080-> nippon ultra blue (#23607f)#206080-> nippon ultra blue (#23607f)#e7f8ff-> nippon ultra blue (#23607f)#cccccc-> nippon ultra blue (#23607f)